Identity: Support include_names query arg in /role_assignments#2133
Merged
jtopjian merged 1 commit intogophercloud:masterfrom Mar 26, 2021
objque:identity-support-include-names-flag-in-role-assignments-endpoint
Merged
Identity: Support include_names query arg in /role_assignments#2133jtopjian merged 1 commit intogophercloud:masterfrom objque:identity-support-include-names-flag-in-role-assignments-endpoint
jtopjian merged 1 commit intogophercloud:masterfrom
objque:identity-support-include-names-flag-in-role-assignments-endpoint
Conversation
Keystone may include names into RoleAssignment entity, if provide include_names=true as query arguemnt doc: https://docs.openstack.org/api-ref/identity/v3/index.html?expanded=id627-detail#id627
Contributor
|
@objque Thanks. Just for reference, API documentation isn't used as it may be outdated. Instead, we need to see the actual Keystone code that defines this feature. This is explained here. For this PR, the following links are relevant:
Please let me know when this PR is ready for review. |
Contributor
Author
|
Yes, you definitely right. In the next PR's I will reference on the actual Keystone code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keystone may include names into RoleAssignment entity, if provide include_names=true as query arguemnt
For #2124
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://docs.openstack.org/api-ref/identity/v3/index.html?expanded=id627-detail#id627