Skip to content

[Identity v3] Add available project listing#2090

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
devholic:auth/projects
Jan 10, 2021
Merged

[Identity v3] Add available project listing#2090
jtopjian merged 1 commit intogophercloud:masterfrom
devholic:auth/projects

Conversation

@devholic
Copy link
Copy Markdown
Contributor

@devholic devholic commented Jan 5, 2021

For #1719

Refers

Changes

Add available project listing

Open Questions

I'm not sure about word available, but if this PR is accepted, I think ListCatalog should be renamed too 🤔 (Since catalog API requires token, rename is not necessary.)

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.006%) to 79.762% when pulling 44c3297 on devholic:auth/projects into e34a44d on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jan 5, 2021

Build succeeded.

@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented Jan 7, 2021

@devholic Thank you for working on this - this looks really good.

I think ListAvailable is fine. "List" because it can return more than one resource and "Available" for the projects accessible to the user.

Let me know when this is ready for review/merge.

@devholic
Copy link
Copy Markdown
Contributor Author

devholic commented Jan 7, 2021

@jtopjian Thanks for comment! 😄

This PR is ready for review. (I ran test on my environment)

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit f5eb9e0 into gophercloud:master Jan 10, 2021
@devholic devholic deleted the auth/projects branch January 10, 2021 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants