Skip to content

Fixes fully-populated loadbalancer creation without default_pool, l7policies or l7rules#2087

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
sapcc:fix-fully-populated-loadbalancer
Jan 5, 2021
Merged

Fixes fully-populated loadbalancer creation without default_pool, l7policies or l7rules#2087
jtopjian merged 1 commit intogophercloud:masterfrom
sapcc:fix-fully-populated-loadbalancer

Conversation

@notandy
Copy link
Copy Markdown
Contributor

@notandy notandy commented Jan 4, 2021

Prior to starting a PR, please make sure you have read our
contributor tutorial.

Prior to a PR being reviewed, there needs to be a Github issue that the PR
addresses. Replace the brackets and text below with that issue number.

For #2086

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

https://github.com/openstack/octavia/blob/master/octavia/api/v2/controllers/load_balancer.py#L500
https://docs.openstack.org/api-ref/load-balancer/v2/?expanded=create-a-load-balancer-detail#creating-a-fully-populated-load-balancer

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 79.743% when pulling d579ef2 on sapcc:fix-fully-populated-loadbalancer into 810f391 on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jan 4, 2021

Build succeeded.

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit fa957f3 into gophercloud:master Jan 5, 2021
@notandy
Copy link
Copy Markdown
Contributor Author

notandy commented Jan 5, 2021

Thank you very much :)

@notandy notandy deleted the fix-fully-populated-loadbalancer branch January 5, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants