Skip to content

Support storage policy on container create#2075

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
iokiwi:new/support-storage-policy-on-create
Dec 21, 2020
Merged

Support storage policy on container create#2075
jtopjian merged 1 commit intogophercloud:masterfrom
iokiwi:new/support-storage-policy-on-create

Conversation

@iokiwi
Copy link
Copy Markdown
Contributor

@iokiwi iokiwi commented Dec 17, 2020

For #2074
Fixes #2074

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 79.74% when pulling fefdef0 on iokiwi:new/support-storage-policy-on-create into 3647be3 on gophercloud:master.

@jtopjian
Copy link
Copy Markdown
Contributor

recheck

1 similar comment
@jtopjian
Copy link
Copy Markdown
Contributor

recheck

@jtopjian
Copy link
Copy Markdown
Contributor

Something seems wonky with OpenLab. I'm inclined to go ahead ad merge this anyway, though. Is this ready for review/merge?

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Dec 18, 2020

Build succeeded.

@iokiwi
Copy link
Copy Markdown
Contributor Author

iokiwi commented Dec 20, 2020

@jtopjian yep I am happy for it to be merged if you are fine with the state of the build. I tested manually

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit 3383133 into gophercloud:master Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support storage policy on container create

3 participants