Skip to content

Cleanup: fix formatting#2068

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
Fedosin:fix_fmt
Dec 12, 2020
Merged

Cleanup: fix formatting#2068
jtopjian merged 1 commit intogophercloud:masterfrom
Fedosin:fix_fmt

Conversation

@Fedosin
Copy link
Copy Markdown
Contributor

@Fedosin Fedosin commented Dec 7, 2020

Generated by gofmt -s -w .

For #2071

Generated by `gofmt -s -w .`
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 79.676% when pulling ecff427 on Fedosin:fix_fmt into b971228 on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Dec 7, 2020

Build failed.

@Fedosin
Copy link
Copy Markdown
Contributor Author

Fedosin commented Dec 7, 2020

recheck

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Dec 7, 2020

Build succeeded.

@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented Dec 8, 2020

@Fedosin Thanks for doing this. This looks good to me. Let me know if you're ready to have this merged or if you were going to do any other work.

@pierreprinetti
Copy link
Copy Markdown
Member

LGTM! 🐐

@jtopjian What about adding gofmt to the CI? And speaking of CI, do you have plans already for the after-Travis?

@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented Dec 9, 2020

@pierreprinetti regarding gofmt, see my comments here: gophercloud/utils#133

This repo is currently using goimports to check for both code formatting and "import" statement stuff. The only area it's lacking is the -s flag for code simplification. For that, I'm on the fence. If someone wants to put the work into modifying the current script to do both goimports and gofmt, I'm happy to merge it. Otherwise, the basic formatting support that already exists is sufficient, IMO.

Regarding Travis... ugh. This is news to me. I'll have to look into it and see what options are available. Thank you for the heads-up.

@Fedosin
Copy link
Copy Markdown
Contributor Author

Fedosin commented Dec 11, 2020

@jtopjian yeah, the work (at least for this PR) is complete. we can merge it.

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit 3647be3 into gophercloud:master Dec 12, 2020
@jtopjian jtopjian mentioned this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants