[Identity v3] Add service catalog listing#2067
Conversation
|
Build succeeded.
|
aaa5a80 to
219f98f
Compare
|
Build succeeded.
|
|
@outcatcher Thanks for working on this. Please let me know if this is ready for review. |
|
@jtopjian It's already ready to be reviewed. |
jtopjian
left a comment
There was a problem hiding this comment.
LGTM - thank you!
A few nits for the next PR:
-
The following area of code better defines this API call: https://github.com/openstack/keystone/blob/master/keystone/api/auth.py#L230. You can see how this code calls the code that you provided. It also defines the JSON response structure.
-
When possible, please try not to use the JSON responses from the API documentation for unit tests. Please try to obtain an actual JSON response from a live environment.
As an example, search this link (https://logs.openlabtesting.org/logs/67/2067/219f98f8514e6f150450b4d1bda325f73f7b6c5d/check/gophercloud-acceptance-test/ce06b4b/job-output.txt.gz) for TestCatalogList. You'll see the JSON requests and responses included in this output file. The JSON response is slightly different than the API documentation in that it includes more than one service as well as includes a region_id field.
The fixture you used is good enough to keep, so just a nit.
All in all, really nice work - thank you for submitting this!
For #1719 (one of four requested resources)
Add support of service catalog list
API reference:
https://docs.openstack.org/api-ref/identity/v3/?expanded=get-service-catalog-detail#get-service-catalog
Implementation:
https://github.com/openstack/keystone/blob/stable/victoria/keystone/catalog/core.py#L237