Add missing options to member types#2056
Merged
jtopjian merged 1 commit intogophercloud:masterfrom Nov 23, 2020
Merged
Conversation
|
Build succeeded.
|
This adds Backup, MonitorAddress, MonitorPort and Tags to member types. **`CreateMemberOpts`** [Documentation](https://docs.openstack.org/api-ref/load-balancer/v2/?expanded=create-member-detail#create-member) [Code](https://github.com/openstack/octavia/blob/198980639cbe02820f90783fa04d5239717ed80d/octavia/api/v2/types/member.py#L87) **`UpdateMemberOpts`** [Documentation](https://docs.openstack.org/api-ref/load-balancer/v2/?expanded=update-a-member-detail#update-a-member) [Code](https://github.com/openstack/octavia/blob/198980639cbe02820f90783fa04d5239717ed80d/octavia/api/v2/types/member.py#L100-L104) **`BatchUpdateMemberOpts`** [Documentation](https://docs.openstack.org/api-ref/load-balancer/v2/?expanded=batch-update-members-detail#batch-update-members) [Code](https://github.com/openstack/octavia/blob/198980639cbe02820f90783fa04d5239717ed80d/octavia/api/v2/types/member.py#L79-L87)
e739ce0 to
d205415
Compare
|
Build succeeded.
|
jtopjian
approved these changes
Nov 23, 2020
|
|
||
| // An alternate IP address used for health monitoring a backend member. | ||
| MonitorAddress string `json:"monitor_address,omitempty"` | ||
| MonitorAddress *string `json:"monitor_address,omitempty"` |
Contributor
There was a problem hiding this comment.
Sorry - this can stay string.
It's only in the UpdateMemberOpts and UpdateMemberOpts where it needs to be *string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #2055
This adds Backup, MonitorAddress, MonitorPort and Tags to member types.
Links to the line numbers/files in the OpenStack source code that support the code in this PR:
CreateMemberOptsDocumentation
Code
UpdateMemberOptsDocumentation
Code
BatchUpdateMemberOptsDocumentation
Code