Networking / routers: Allow updating routers, without specifying the static routes#2043
Merged
jtopjian merged 3 commits intogophercloud:masterfrom Oct 31, 2020
Merged
Networking / routers: Allow updating routers, without specifying the static routes#2043jtopjian merged 3 commits intogophercloud:masterfrom
jtopjian merged 3 commits intogophercloud:masterfrom
Conversation
This is helpful when it is necessary to rename a router, but it is not desired by the user to touch the static routes. The OpenStack API just allows to omit the static routes (e.g. verifyable with `openstack router set --name new_name --debug`). This change makes sure that static routes parameter can be omitted with gophercloud as well. Also added a unit test.
|
Build failed.
|
Contributor
|
recheck |
|
Build failed.
|
Contributor
Author
|
I also noticed that the documentation needed an update. @jtopjian I am not sure how I can see what fails in the acceptance test – or is it just flaky? Thanks for sending the retest command ;) |
Contributor
|
@stefreak The full suite usually takes 2-3 hours, so 1.5hrs may be pointing to an issue with OpenLab. It happens from time to time. Let's give it a day and if it's still failing, I'll open a ticket. If I get some time, I'll run the tests in devstack to confirm if any of them need updating from this change. |
|
Build failed.
|
Contributor
Author
|
recheck |
|
Build failed.
|
Contributor
|
From the logs, it looks like the devstack installation is not completing successfully. I'll give it one more try and then open a ticket. |
Contributor
|
recheck |
|
Build succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is helpful when it is necessary to rename a router,
but it is not desired by the user to touch the static routes.
The OpenStack API just allows to omit the static routes (e.g.
verifyable with
openstack router set --name new_name --debug).This change makes sure that static routes parameter can be omitted with
gophercloud as well.
Also added a unit test.
For #2044
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
(I could not find a specific line of code, but provided the openstack CLI command for quick verification that this works above)