Skip to content

Add ip, ip6, and user_id to servers.ListOpts#2038

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
sfiera:servers
Oct 5, 2020
Merged

Add ip, ip6, and user_id to servers.ListOpts#2038
jtopjian merged 1 commit intogophercloud:masterfrom
sfiera:servers

Conversation

@sfiera
Copy link
Copy Markdown
Contributor

@sfiera sfiera commented Oct 5, 2020

Add ip, ip6, and user_id to servers.ListOpts

As listed in https://docs.openstack.org/api-guide/compute/server_concepts.html#server-query:

  • ip
  • ip6 (New in version 2.5)
  • user_id (New in version 2.83)

And the CLI documentation:

--ip <ip-address-regex>
                      Regular expression to match IP addresses
--ip6 <ip-address-regex>
                      Regular expression to match IPv6 addresses. Note that
                      this option only applies for non-admin users when
                      using ``--os-compute-api-version`` 2.5 or greater.
--user <user>         Search by user (admin only) (name or ID)

Note the difference between the user_id docs. My understanding is that
it’s the same as ip6: the option was initially admin-only, and became
generally available with API 2.83 (this is what I have documented).

For #2035

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

https://github.com/openstack/nova/blob/a948a803b561606a892133940915caae610c080b/nova/api/openstack/compute/schemas/servers.py#L567

As listed in https://docs.openstack.org/api-guide/compute/server_concepts.html#server-query:
* ip
* ip6 (New in version 2.5)
* user_id (New in version 2.83)

And the CLI documentation:

    --ip <ip-address-regex>
                          Regular expression to match IP addresses
    --ip6 <ip-address-regex>
                          Regular expression to match IPv6 addresses. Note that
                          this option only applies for non-admin users when
                          using ``--os-compute-api-version`` 2.5 or greater.
    --user <user>         Search by user (admin only) (name or ID)

Note the difference between the user_id docs. My understanding is that
it’s the same as ip6: the option was initially admin-only, and became
generally available with API 2.83 (this is what I have documented).

For gophercloud#2035
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 79.585% when pulling 37bb925 on sfiera:servers into 841705f on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Oct 5, 2020

Build succeeded.

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit ca2a158 into gophercloud:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants