Skip to content

LoadBalancer V2: implement quotas.Update#2023

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
mercedes-benz:loadbalancersv2-quotas-update
Sep 22, 2020
Merged

LoadBalancer V2: implement quotas.Update#2023
jtopjian merged 1 commit intogophercloud:masterfrom
mercedes-benz:loadbalancersv2-quotas-update

Conversation

@chrischdi
Copy link
Copy Markdown
Contributor

@chrischdi chrischdi commented Sep 18, 2020

Add openstack/loadbalancer/v2/quotas.Update.

Add unit and acceptance tests.

For #1826

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

I did not implement any handling for load_balancer or health_monitor for now. Duplicating the values and adding these to the json request too leads to a 400 from API side.

However the not-deprecated way (loadbalancer and healthmonitor) did work for me on two different stacks.

Christian Schlotter , Daimler TSS GmbH, Imprint

@chrischdi
LoadBalancer V2: implement quotas.Update
1af8453 
Signed-off-by: Schlotter, Christian <christian.schlotter@daimler.com>
@chrischdi chrischdi force-pushed the loadbalancersv2-quotas-update branch from ce20d21 to 1af8453 Compare September 18, 2020 12:04
@coveralls
Copy link
Copy Markdown

coveralls commented Sep 18, 2020

Coverage Status

Coverage increased (+0.003%) to 79.549% when pulling 1af8453 on Daimler:loadbalancersv2-quotas-update into 5690aed on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Sep 18, 2020

Build failed.

@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented Sep 18, 2020

recheck

@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented Sep 18, 2020

Let's ignore the Travis error for now. I'm not sure if it's a temporary issue with the master branch of Go or if we need to change something with go.sum:

https://travis-ci.org/github/gophercloud/gophercloud/jobs/728307527

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Sep 18, 2020

Build failed.

@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented Sep 19, 2020

recheck

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Sep 19, 2020

Build failed.

@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented Sep 20, 2020

And from what I can tell, the OpenLab tests are failing because devstack is failing (https://logs.openlabtesting.org/logs/23/2023/1af845341e457a4a63729a936a1c2c83c164c3fa/check/gophercloud-acceptance-test/18184f6/logs/devstacklog.txt). Maybe this will fix itself in another day or two. If not, I'll open an issue with OpenLab.

However, this all looks good to me. Let me know if you've tested this and it works. If you have and it does, I can merge this.

@chrischdi
Copy link
Copy Markdown
Contributor Author

chrischdi commented Sep 21, 2020

And from what I can tell, the OpenLab tests are failing because devstack is failing (https://logs.openlabtesting.org/logs/23/2023/1af845341e457a4a63729a936a1c2c83c164c3fa/check/gophercloud-acceptance-test/18184f6/logs/devstacklog.txt). Maybe this will fix itself in another day or two. If not, I'll open an issue with OpenLab.

However, this all looks good to me. Let me know if you've tested this and it works. If you have and it does, I can merge this.

Hi @jtopjian,

thank you for looking at it :-)

I tested it locally on two stacks (acceptance tests) however, I had to comment out the RequireAdmin part, because I had a some-what admin, which does not match this function.

However I'd be also ok with waiting for OpenLab :-)

@chrischdi
Copy link
Copy Markdown
Contributor Author

chrischdi commented Sep 21, 2020

recheck

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Sep 21, 2020

Build failed.

jtopjian
jtopjian approved these changes Sep 22, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit ba31f2c into gophercloud:master Sep 22, 2020
@cwrau cwrau mentioned this pull request Feb 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtopjian jtopjian jtopjian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chrischdi @coveralls @jtopjian