Coverage remained the same at 79.547% when pulling 2815a42 on galuszkak:feature/messaging-update into d0d95a0 on gophercloud:master.

@galuszkak Thank you for submitting this.

Per the contributor tutorial linked above, API doc references aren't enough to determine if this is a valid OpenStack feature. Please see Step 3 specifically and let me know if you have any questions.

Hi @jtopjian ,

If I understand your ask correctly does below proofs are enough, or there is something still needed?
https://github.com/openstack/zaqar/blob/master/zaqar/transport/validation.py#L344-L347
openstack/zaqar@e12c65a

Thanks for helping!

@galuszkak Yes, that's perfect 🙂

One extra thing to consider here is that you have a combination of bool and omitempty. This means that a value of false will never be sent in the JSON request. According to the service-side code (https://github.com/openstack/zaqar/blob/master/zaqar/transport/validation.py#L344), the default value is false, so this combination should be fine. However, if you want the ability to explicitly send a value of false, this will need changed to *bool.

There's also some ListOpts fields you've added in this PR. We'll need to dig up the code references for those, too. Alternatively, you can leave them out of this PR and submit them in a new PR.

@jtopjian thanks for feedback.

I've applied it. I will sent name and with_count in separate PR as it makes more sense to seperate those changes.

Build succeeded.

• gophercloud-unittest : SUCCESS in 2m 44s
• gophercloud-acceptance-test : SUCCESS in 1h 51m 18s
• gophercloud-acceptance-test-ironic : SUCCESS in 55m 31s