Skip to content

support TERMINATED_HTTPS protocol for listeners#1992

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
hamzazafar:add-terminated-https-listener-protocol
Jul 21, 2020
Merged

support TERMINATED_HTTPS protocol for listeners#1992
jtopjian merged 1 commit intogophercloud:masterfrom
hamzazafar:add-terminated-https-listener-protocol

Conversation

@hamzazafar
Copy link
Copy Markdown
Contributor

@hamzazafar hamzazafar commented Jul 21, 2020

For 1991

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 79.416% when pulling 64275fb on hamzazafar:add-terminated-https-listener-protocol into c8c96f7 on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jul 21, 2020

Build succeeded.

@kayrus
Copy link
Copy Markdown
Contributor

kayrus commented Jul 21, 2020

@hamzazafar fyi: you san simply convert any string to a Protocol type and use it in struct. See an example in terraform provider: https://github.com/terraform-providers/terraform-provider-openstack/blob/152286f9ae3d016cb38d53ae2c0d1920d967d368/openstack/lb_v2_shared.go#L74

Probably it does make sense to add all supported protocols, or simply convert the type to a string.

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this was ready for a review and is good to go. Apologies if not.

LGTM - thank you!

@jtopjian jtopjian merged commit b9450e7 into gophercloud:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants