Skip to content

Support http_basic auth_strategy for Ironic Inspector#1986

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
iurygregory:ironic-inspector-http_basic
Jun 24, 2020
Merged

Support http_basic auth_strategy for Ironic Inspector#1986
jtopjian merged 1 commit intogophercloud:masterfrom
iurygregory:ironic-inspector-http_basic

Conversation

@iurygregory
Copy link
Copy Markdown
Contributor

For #1485

Ironic Inspector introduced a new auth_type http_basic that can
be used in standalone deployments. The code was introduced by the change [1]

This commit adds the support to use the new authentication
type.

[1] https://review.opendev.org/#/c/729463/

Ironic Inspector introduced a new auth_type http_basic that can
be used in standalone deployments. The code was introduced by [1]

This commit adds the support to use the new authentication
type.

[1] https://review.opendev.org/#/c/729463/
@iurygregory iurygregory force-pushed the ironic-inspector-http_basic branch from f4d0845 to 5f8b2f7 Compare June 23, 2020 14:47
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 23, 2020

Coverage Status

Coverage increased (+0.02%) to 79.397% when pulling 5f8b2f7 on iurygregory:ironic-inspector-http_basic into 1f9e326 on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jun 23, 2020

Build failed.

@iurygregory
Copy link
Copy Markdown
Contributor Author

/recheck

@jtopjian
Copy link
Copy Markdown
Contributor

recheck

@jtopjian
Copy link
Copy Markdown
Contributor

It looks like an issue with OpenLab. The environment isn't getting to a point where the tests are running. Hopefully just a temporary issue.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jun 23, 2020

Build succeeded.

@jtopjian
Copy link
Copy Markdown
Contributor

@iurygregory This looks good to me - thanks!

Let me know if you're ready to have this merged.

@iurygregory
Copy link
Copy Markdown
Contributor Author

@jtopjian we can merge this one =)

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit 95b3c57 into gophercloud:master Jun 24, 2020
@iurygregory iurygregory deleted the ironic-inspector-http_basic branch October 13, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants