Support http_basic auth_strategy for Ironic Inspector#1986
Merged
jtopjian merged 1 commit intogophercloud:masterfrom Jun 24, 2020
Merged
Support http_basic auth_strategy for Ironic Inspector#1986jtopjian merged 1 commit intogophercloud:masterfrom
jtopjian merged 1 commit intogophercloud:masterfrom
Conversation
Ironic Inspector introduced a new auth_type http_basic that can be used in standalone deployments. The code was introduced by [1] This commit adds the support to use the new authentication type. [1] https://review.opendev.org/#/c/729463/
f4d0845 to
5f8b2f7
Compare
|
Build failed.
|
Contributor
Author
|
/recheck |
Contributor
|
recheck |
Contributor
|
It looks like an issue with OpenLab. The environment isn't getting to a point where the tests are running. Hopefully just a temporary issue. |
|
Build succeeded.
|
Contributor
|
@iurygregory This looks good to me - thanks! Let me know if you're ready to have this merged. |
Contributor
Author
|
@jtopjian we can merge this one =) |
61 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1485
Ironic Inspector introduced a new auth_type http_basic that can
be used in standalone deployments. The code was introduced by the change [1]
This commit adds the support to use the new authentication
type.
[1] https://review.opendev.org/#/c/729463/