Modify PhysicalDisks's type to support physical disks hints#1982
Modify PhysicalDisks's type to support physical disks hints#1982jtopjian merged 1 commit intogophercloud:masterfrom zouy414:master
Conversation
|
Build succeeded.
|
|
@Hellcatlk Thanks for submitting this. Per our contributor's guide, we also need to see the API service code that proves this change is valid. Let me know if you have any questions or need any help. |
jtopjian
left a comment
There was a problem hiding this comment.
Sorry - 1 change. Please let me know if you have any questions.
go.mod
Outdated
| @@ -1,5 +1,7 @@ | |||
| module github.com/gophercloud/gophercloud | |||
|
|
|||
| go 1.14 | |||
There was a problem hiding this comment.
whoops - actually, I just noticed that Travis is flagging an error and I think it's due to this. Can you remove this?
We can probably get rid of the Go 1.11 tests altogether, but I will do that in a separate PR when I get some time. Until then, removing this will be the fastest way.
There was a problem hiding this comment.
Sorry , I forget delete it. This is auto added by IDE.
|
Build failed.
|
|
|
||
| // A list of physical disks to use as read by the RAID interface. | ||
| PhysicalDisks []string `json:"physical_disks,omitempty"` | ||
| PhysicalDisks interface{} `json:"physical_disks,omitempty"` |
There was a problem hiding this comment.
What do you think about interface{} and []interface{}?
interface {} is easy to use, but [] interface {} can make the input must be a list.
There was a problem hiding this comment.
[]interface{} would be more strict and that's more appealing than a generic interface{}. Sure, let's go with that.
|
Build failed.
|
Signed-off-by: ZouYu <zouy.fnst@cn.fujitsu.com>
|
@jtopjian Thanks, done. |
|
Build succeeded.
|
For #1981
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L2999
https://github.com/openstack/ironic/blob/master/ironic/common/raid.py#L63
https://github.com/openstack/ironic/blob/master/ironic/drivers/raid_config_schema.json#L59