Skip to content

fix: leak of goroutines on re-auth#1978

Merged
jtopjian merged 2 commits intogophercloud:masterfrom
pamburus:feature/reauth
Jun 11, 2020
Merged

fix: leak of goroutines on re-auth#1978
jtopjian merged 2 commits intogophercloud:masterfrom
pamburus:feature/reauth

Conversation

@pamburus
Copy link
Copy Markdown
Contributor

@pamburus pamburus commented Jun 5, 2020

For #1977

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 5, 2020

Coverage Status

Coverage decreased (-0.0008%) to 79.379% when pulling 639b673 on pamburus:feature/reauth into d139d60 on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jun 5, 2020

Build succeeded.

@kayrus
Copy link
Copy Markdown
Contributor

kayrus commented Jun 8, 2020

@majewsky could you please review this PR?

@majewsky
Copy link
Copy Markdown
Contributor

majewsky commented Jun 9, 2020

I commented on #1977.

@pamburus
Copy link
Copy Markdown
Contributor Author

@majewsky
According to the result of discussion in #1977 can we merge this Pull Request?

Copy link
Copy Markdown
Contributor

@majewsky majewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this fixes the goroutine leak exposed by the testcase from #1977. The logic looks correct as far as I can see.

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pamburus Thank you for raising this issue and providing a fix.

@majewsky Thank you for reviewing.

@jtopjian jtopjian merged commit d48e557 into gophercloud:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants