switch bootfromvolume from os-volumes_boot to servers#1973
switch bootfromvolume from os-volumes_boot to servers#1973jtopjian merged 1 commit intogophercloud:masterfrom
Conversation
|
Build succeeded.
|
|
recheck stable/newton |
|
Build failed.
|
|
recheck stable/ocata |
|
Build failed.
|
|
recheck stable/pike |
|
@jichenjc Thanks for submitting this. I'd like to make sure this change doesn't break with older releases of openstack, but it appears there's an issue with running these tests. I'll have to open an issue about this. |
|
Build failed.
|
|
thanks a lot for the help, yes, I saw the test is not running well |
|
recheck stable/queens |
|
recheck stable/rocky |
|
recheck stable/stein |
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
recheck stable/stein |
|
Build failed.
|
|
recheck |
|
recheck stable/stein |
|
recheck stable/rocky |
|
recheck stable/queens |
|
Build failed.
|
|
@wangxiyuan It looks like tests for "stein" are correctly running. The test failure seems legitimate and something I can look into later. Everything before stein seems to not even start, though. |
|
Build failed.
|
|
recheck stable/pike |
|
recheck stable/ocata |
|
recheck stable/newton |
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
@jtopjian devstack failed setup before rocky release. It needs more time to debug. I guess it related to somthing with python3 or ubuntu version adoption. |
|
Build failed.
|
|
Build failed.
|
Thank you so much for looking into this. Please take all the time you need :) |
|
@wangxiyuan thanks, yes, I think py2->3 and ubuntu upgrade might be a challange as some older releases has been unsupported by community itself https://releases.openstack.org/ |
|
It looks like all jobs are being run on Ubuntu Bionic? If so, is it possible to have certain older jobs run on Ubuntu Xenial? As for older jobs, I try to test with as many older releases as possible as that's what reflects real-world deployments. That's key for changes such as what this PR is doing. But if we have to drop support for some releases, then we can drop Ocata and Pike. |
|
openlab has Ubuntu 16.04 node. It's called https://github.com/gophercloud/gophercloud/blob/master/.zuul.yaml#L23 Just override it in the job you want. |
|
@wangxiyuan Thanks! I'm testing this in #1975 |
|
@jichenjc I've merged #1975 which should help fix the issue with the immediate test failures. Can you rebase this PR off of master to pull in the new It's OK if the entire test suite fails. I just want to make sure that changing this URL isn't going to break support in older releases. From looking through the git history, this URL alias has been in place for a number of years, so we should be safe. I just want to double check. Thank you for your patience with this. |
according to https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/routes.py#L726 os-volumes_boot is identical to servers routes and it will be deprecated later https://docs.openstack.org/api-ref/compute/ os-volumes_boot is not listed at all so switch from os-volumes_boot to servers
c68c41e to
c693a9c
Compare
|
@jtopjian thanks for the info and the fix for older releases I rebased just now and hopefully it helps |
|
Build failed.
|
|
recheck |
|
recheck stable/ocata |
|
Build failed.
|
|
Build succeeded.
|
jtopjian
left a comment
There was a problem hiding this comment.
Looks like the relevant Boot From Volume tests are passing as far back as Ocata, so I think this should be safe to merge.
Thank you for your patience with this.
|
thanks a lot for the help :) |
according to
https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/routes.py#L726
os-volumes_boot is identical to servers routes and it will be deprecated later
https://docs.openstack.org/api-ref/compute/
os-volumes_boot is not listed at all
so switch from os-volumes_boot to servers
For #1974