Skip to content

Glance V2: Add create action response headers support#1962

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
kayrus:glance-headers
May 15, 2020
Merged

Glance V2: Add create action response headers support#1962
jtopjian merged 1 commit intogophercloud:masterfrom
kayrus:glance-headers

Conversation

@kayrus
Copy link
Copy Markdown
Contributor

@kayrus kayrus commented May 11, 2020

resolves #1961

@coveralls
Copy link
Copy Markdown

coveralls commented May 11, 2020

Coverage Status

Coverage increased (+0.02%) to 79.385% when pulling 4a84653 on kayrus:glance-headers into 4113412 on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented May 11, 2020

Build failed.

@jtopjian
Copy link
Copy Markdown
Contributor

That Travis error is unrelated, but is flagging an error with tip. This could be a temporary issue or a sign that we're going to have to dive into the most complicated part of Gophercloud...

@jtopjian
Copy link
Copy Markdown
Contributor

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented May 12, 2020

recheck

1 similar comment
@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented May 13, 2020

recheck

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented May 13, 2020

Build succeeded.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented May 13, 2020

@jtopjian ready for review

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented May 14, 2020

Build failed.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented May 14, 2020

recheck

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented May 14, 2020

Build succeeded.

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit 6cd283d into gophercloud:master May 15, 2020
@kayrus kayrus deleted the glance-headers branch May 15, 2020 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Glance V2: Add create action response headers support

3 participants