Skip to content

Networking V2: Update/Delete/ScheduleDHCP/RemoveDHCP on network agents#1954

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
kayrus:agents
Apr 26, 2020
Merged

Networking V2: Update/Delete/ScheduleDHCP/RemoveDHCP on network agents#1954
jtopjian merged 1 commit intogophercloud:masterfrom
kayrus:agents

Conversation

@kayrus
Copy link
Copy Markdown
Contributor

@kayrus kayrus commented Apr 22, 2020

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 22, 2020

Coverage Status

Coverage increased (+0.006%) to 79.308% when pulling ed3a9a6 on kayrus:agents into 456b0b6 on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Apr 22, 2020

Build succeeded.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Apr 22, 2020

@jtopjian ready for review

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kayrus Just one change with regard to the builder method name.

Everything else looks good - I validated these changes with the Neutron service code and added the links to the description of this PR.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Apr 23, 2020

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Apr 23, 2020

Build succeeded.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Apr 25, 2020

@jtopjian renamed the func as suggested

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit f307d49 into gophercloud:master Apr 26, 2020
@kayrus kayrus deleted the agents branch April 26, 2020 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Networking V2: Agents API

3 participants