Add extra and option fields to project#1951
Merged
jtopjian merged 3 commits intogophercloud:masterfrom Apr 29, 2020
Merged
Conversation
|
Build succeeded.
|
|
Build succeeded.
|
Contributor
Author
|
Is there something I can do? |
jtopjian
approved these changes
Apr 29, 2020
Contributor
jtopjian
left a comment
There was a problem hiding this comment.
@johscheuer Sorry - I was waiting for confirmation that this was done and ready for review :)
This LGTM - thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to starting a PR, please make sure you have read our
contributor tutorial.
Prior to a PR being reviewed, there needs to be a Github issue that the PR
addresses. Replace the brackets and text below with that issue number.
For #1004
Links to the line numbers/files in the OpenStack source code that support the
code in this PR: Most information is in the issue