Skip to content

Core: set response headers for all requests#1942

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
kayrus:response-headers
Apr 19, 2020
Merged

Core: set response headers for all requests#1942
jtopjian merged 1 commit intogophercloud:masterfrom
kayrus:response-headers

Conversation

@kayrus
Copy link
Copy Markdown
Contributor

@kayrus kayrus commented Apr 18, 2020

Resolves #1170

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 18, 2020

Coverage Status

Coverage increased (+0.3%) to 79.004% when pulling c8735ae on kayrus:response-headers into 53d02bc on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Apr 18, 2020

Build failed.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Apr 18, 2020

recheck

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Apr 18, 2020

Build failed.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Apr 18, 2020

recheck

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Apr 18, 2020

Build succeeded.

@kayrus kayrus force-pushed the response-headers branch from de61592 to c8735ae Compare April 19, 2020 08:40
@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Apr 19, 2020

@jtopjian ready for review. This PR also fixes potential null pointer exceptions.

I mentioned places, where you may want to get some clarifications:

@kayrus kayrus marked this pull request as ready for review April 19, 2020 08:41
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Apr 19, 2020

Build succeeded.

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give this a try and see what happens.

@jtopjian jtopjian merged commit 41c3197 into gophercloud:master Apr 19, 2020
@kayrus kayrus deleted the response-headers branch April 19, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bugfix: Headers not be set

3 participants