Skip to content

Cinder V3: Add support for Cinders Attachment API#1934

Merged
jtopjian merged 2 commits intogophercloud:masterfrom
kayrus:cinder-attachments
Apr 12, 2020
Merged

Cinder V3: Add support for Cinders Attachment API#1934
jtopjian merged 2 commits intogophercloud:masterfrom
kayrus:cinder-attachments

Conversation

@kayrus
Copy link
Copy Markdown
Contributor

@kayrus kayrus commented Apr 10, 2020

Resolves #414

@kayrus kayrus force-pushed the cinder-attachments branch from a83a2af to b56a084 Compare April 10, 2020 23:39
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 10, 2020

Coverage Status

Coverage increased (+0.03%) to 78.597% when pulling cb1a0b3 on kayrus:cinder-attachments into 198dfc0 on gophercloud:master.

@kayrus kayrus force-pushed the cinder-attachments branch from b56a084 to 70cc8e6 Compare April 11, 2020 00:09
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Apr 11, 2020

Build failed.

@kayrus kayrus force-pushed the cinder-attachments branch 3 times, most recently from 4150a9b to 1d311f2 Compare April 11, 2020 07:23
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Apr 11, 2020

Build failed.

@kayrus kayrus force-pushed the cinder-attachments branch from 1d311f2 to 10f5ec5 Compare April 11, 2020 09:55
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Apr 11, 2020

Build failed.

@kayrus kayrus force-pushed the cinder-attachments branch from 10f5ec5 to 2f8b431 Compare April 11, 2020 12:22
@kayrus kayrus force-pushed the cinder-attachments branch from 2f8b431 to cb1a0b3 Compare April 11, 2020 14:03
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Apr 11, 2020

Build failed.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Apr 11, 2020

recheck

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Apr 11, 2020

Build succeeded.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Apr 11, 2020

@jtopjian ready for review

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit 102532a into gophercloud:master Apr 12, 2020
@kayrus kayrus deleted the cinder-attachments branch April 13, 2020 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No support for new V3.27 Cinder Attachment API

3 participants