Keystone V3: Introduce TOTP (two factor) auth support#1922
Merged
jtopjian merged 2 commits intogophercloud:masterfrom Apr 6, 2020
Merged
Keystone V3: Introduce TOTP (two factor) auth support#1922jtopjian merged 2 commits intogophercloud:masterfrom
jtopjian merged 2 commits intogophercloud:masterfrom
Conversation
|
Build succeeded.
|
Contributor
I'm OK with skipping tests on this one - I understand it can be difficult. As long as you've confirmed it works in some environment, that's good enough for me. One style request for this PR: let's use |
|
Build succeeded.
|
Contributor
|
@kayrus This looks good to me. Are you still working on it or is it ready to be merged? |
Contributor
Author
|
@jtopjian ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1917
@jtopjian I didn't find a way to perform tests in multi-step approach https://docs.openstack.org/api-ref/identity/v3/?expanded=multi-step-authentication-2-factor-password-and-totp-example-detail#multi-step-authentication-2-factor-password-and-totp-example
In my case passcodes are generated using a dongle and I can enter them in advance, therefore the auth request sends both password and totp auth requests in one call.
I'll try to add a receipt response handler in further PRs.