Skip to content

include response headers in ErrUnexpectedResponseCode#1919

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
sapcc:error-response-headers
Apr 3, 2020
Merged

include response headers in ErrUnexpectedResponseCode#1919
jtopjian merged 1 commit intogophercloud:masterfrom
sapcc:error-response-headers

Conversation

@majewsky
Copy link
Copy Markdown
Contributor

@majewsky majewsky commented Apr 2, 2020

Possible usecases include:

  • including the X-Openstack-Request-Id when logging the error message
  • respecting the Retry-After header when backing off after a 429 response

Solves #1918.

Possible usecases include:
- including the X-Openstack-Request-Id when logging the error message
- respecting the Retry-After header when backing off after a 429 response

Solves gophercloud#1918.
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.0009%) to 78.706% when pulling fb40fd4 on sapcc:error-response-headers into e2dceb1 on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Apr 2, 2020

Build succeeded.

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit 29b4a4a into gophercloud:master Apr 3, 2020
@majewsky majewsky deleted the error-response-headers branch April 3, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants