Skip to content

Keystone V3: Support EC2 credentials CRD#1916

Merged
jtopjian merged 2 commits intogophercloud:masterfrom
kayrus:ec2creds
Apr 2, 2020
Merged

Keystone V3: Support EC2 credentials CRD#1916
jtopjian merged 2 commits intogophercloud:masterfrom
kayrus:ec2creds

Conversation

@kayrus
Copy link
Copy Markdown
Contributor

@kayrus kayrus commented Apr 1, 2020

resolves #1913

@kayrus kayrus force-pushed the ec2creds branch 2 times, most recently from 7c23834 to 6240dee Compare April 1, 2020 14:03
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 1, 2020

Coverage Status

Coverage increased (+0.04%) to 78.745% when pulling 04b7b4d on kayrus:ec2creds into e2dceb1 on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Apr 1, 2020

Build succeeded.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Apr 1, 2020

@jtopjian ready for review

@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented Apr 2, 2020

@kayrus This looks good - nice work! Can you add an example to doc.go?

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Apr 2, 2020

Build succeeded.

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit 08898e5 into gophercloud:master Apr 2, 2020
@kayrus kayrus deleted the ec2creds branch April 2, 2020 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keystone V3: Add support for EC2 credentials CRD

3 participants