Fix orchestration template parsing#1915
Merged
jtopjian merged 3 commits intogophercloud:masterfrom Apr 3, 2020
andrein:orchestration_get_file
Merged
Fix orchestration template parsing#1915jtopjian merged 3 commits intogophercloud:masterfrom andrein:orchestration_get_file
jtopjian merged 3 commits intogophercloud:masterfrom
andrein:orchestration_get_file
Conversation
When get_file is used in a template and the referenced file is not json/yaml, gophercloud throws a cryptic error: "Data in neither json nor yaml format."
|
Build succeeded.
|
jtopjian
reviewed
Apr 2, 2020
|
Build succeeded.
|
|
Build failed.
|
Contributor
Author
|
recheck |
Contributor
|
@andrein Thank you for fixing this issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When get_file is used in a template and the referenced file is not json/yaml,
gophercloud throws a cryptic error: "Data in neither json nor yaml format."
For #1914