Skip to content

Cinder V3: Support a backup record export and import#1894

Merged
jtopjian merged 6 commits intogophercloud:masterfrom
kayrus:export-import-backup
Mar 15, 2020
Merged

Cinder V3: Support a backup record export and import#1894
jtopjian merged 6 commits intogophercloud:masterfrom
kayrus:export-import-backup

Conversation

@kayrus
Copy link
Copy Markdown
Contributor

@kayrus kayrus commented Mar 12, 2020

Resolves #1892

@kayrus kayrus force-pushed the export-import-backup branch from 340f392 to 6f41a47 Compare March 12, 2020 10:58
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Mar 12, 2020

Build succeeded.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Mar 12, 2020 •
edited
Loading

@jtopjian ready for review. I also added a struct to represent the backup_url data

jtopjian
jtopjian requested changes Mar 12, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kayrus Thanks!

I've left a few comments - let me know if you have any questions. Also, is it possible to implement acceptance tests? Or are these API calls too difficult?

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Mar 12, 2020

Also, is it possible to implement acceptance tests? Or are these API calls too difficult?

It is possible, but you need to:

  • create a volume
  • create a backup
  • wait for backup to be done
  • copy swift container objects to a new container
  • export an old backup
  • delete an old backup and ensure old swift container is removed
  • change a container name of an exported backup struct to a new container name
  • import backup
  • restore a new volume from a backup
  • wait for its status
  • check the volume contents somehow...

@kayrus kayrus force-pushed the export-import-backup branch from ebfba47 to da364f2 Compare March 12, 2020 20:20
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 12, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 77.174% when pulling 68eb4bf on kayrus:export-import-backup into 965816e on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Mar 12, 2020

Build succeeded.

@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented Mar 13, 2020

It is possible, but you need to:

OK, let's skip acceptance tests for this, then.

Have you been able to use this outside of an acceptance test with success?

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Mar 13, 2020

Have you been able to use this outside of an acceptance test with success?

Yes, it worked fine.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Mar 13, 2020

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Mar 13, 2020

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Mar 14, 2020

Build succeeded.

jtopjian
jtopjian approved these changes Mar 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit ac72432 into gophercloud:master Mar 15, 2020
@kayrus kayrus deleted the export-import-backup branch March 15, 2020 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtopjian jtopjian jtopjian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cinder V3: Support a backup record export and import

3 participants

@kayrus @coveralls @jtopjian