Cinder V3: Update a volume’s bootable status#1891
Merged
jtopjian merged 2 commits intogophercloud:masterfrom Mar 13, 2020
Merged
Cinder V3: Update a volume’s bootable status#1891jtopjian merged 2 commits intogophercloud:masterfrom
jtopjian merged 2 commits intogophercloud:masterfrom
Conversation
dc7939a to
a73b00f
Compare
|
Build succeeded.
|
Contributor
Author
|
@jtopjian ready for review |
a73b00f to
d810494
Compare
|
Build succeeded.
|
Contributor
|
This looks good to me. Is there any way to implement a small/quick acceptance test to validate that the field has changed from true/false (or vice versa)? |
|
Build succeeded.
|
Contributor
Author
|
@jtopjian acceptance tests done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1890