Skip to content

Compute V2: Support VMs without a network#1884

Merged
jtopjian merged 2 commits intogophercloud:masterfrom
kayrus:vm-no-network
Mar 11, 2020
Merged

Compute V2: Support VMs without a network#1884
jtopjian merged 2 commits intogophercloud:masterfrom
kayrus:vm-no-network

Conversation

@kayrus
Copy link
Copy Markdown
Contributor

@kayrus kayrus commented Mar 3, 2020

Resolves #1883

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 3, 2020

Coverage Status

Coverage decreased (-0.009%) to 77.116% when pulling 550a76a on kayrus:vm-no-network into d936e68 on gophercloud:master.

@kayrus kayrus force-pushed the vm-no-network branch 2 times, most recently from 2f42de3 to 04f7e0c Compare March 3, 2020 19:01
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Mar 3, 2020

Build failed.

@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented Mar 4, 2020

I'd like to see an acceptance test added to this. If needed, we can wait until OpenLab is working again.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Mar 8, 2020

Build failed.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Mar 9, 2020

Build succeeded.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Mar 9, 2020

recheck

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Mar 9, 2020

Build succeeded.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Mar 9, 2020

@jtopjian done

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kayrus Sorry for the delay - I was traveling.

This LGTM - thank you!

@jtopjian jtopjian merged commit c238f02 into gophercloud:master Mar 11, 2020
@kayrus kayrus deleted the vm-no-network branch March 11, 2020 05:43
@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Mar 11, 2020

@jtopjian no problem at all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compute V2: Allow VMs without a network.

3 participants