Skip to content

Compute V2: Fix userdata result extension#1881

Merged
jtopjian merged 2 commits intogophercloud:masterfrom
kayrus:userdata-typo
Mar 4, 2020
Merged

Compute V2: Fix userdata result extension#1881
jtopjian merged 2 commits intogophercloud:masterfrom
kayrus:userdata-typo

Conversation

@kayrus
Copy link
Copy Markdown
Contributor

@kayrus kayrus commented Mar 3, 2020

Resolves #1880

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 3, 2020

Coverage Status

Coverage decreased (-0.09%) to 77.115% when pulling 0e8ffcb on kayrus:userdata-typo into a875273 on gophercloud:master.

@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented Mar 3, 2020

Renaming userdata to user_data looks correct, but this PR is also introducing a feature where Gophercloud will encode the data on behalf of the user. I don't think we need to include that.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Mar 3, 2020

Build failed.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Mar 3, 2020

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Mar 3, 2020

Build failed.

@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented Mar 3, 2020

create server opts struct method does encode user_data to base64 automatically:

Ahh right. I knew we had support for this, but similar to a few other legacy areas you've been catching, this is ripe for removal. I checked the Terraform provider and it looks like it's passing in a string... so it's leaning on Gophercloud's encoding capability.

Either way, let's keep the result as being encoded. It's not consistent, but IMO it's the right way for Gophercloud to handle it.

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit fb6683c into gophercloud:master Mar 4, 2020
@kayrus kayrus deleted the userdata-typo branch March 4, 2020 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compute V2: Server user data attribute has a typo

3 participants