Skip to content

Cinder V3: Support "protected" and "visibility" parameters in "UploadImageOpts#1873

Merged
jtopjian merged 2 commits intogophercloud:masterfrom
kayrus:upload-to-image-new-opts
Mar 3, 2020
Merged

Cinder V3: Support "protected" and "visibility" parameters in "UploadImageOpts#1873
jtopjian merged 2 commits intogophercloud:masterfrom
kayrus:upload-to-image-new-opts

Conversation

@kayrus
Copy link
Copy Markdown
Contributor

@kayrus kayrus commented Mar 2, 2020

Resolves #1872

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 2, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 77.206% when pulling cd4227f on kayrus:upload-to-image-new-opts into a875273 on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Mar 2, 2020

Build failed.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Mar 2, 2020

@jtopjian ready for review

jtopjian
jtopjian requested changes Mar 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kayrus Thanks - just one minor change. Let me know if you have any questions.

openstack/blockstorage/extensions/volumeactions/requests.go Outdated

// Visibility defines who can see/use the image.
// supported since 3.1 microversion
Visibility images.ImageVisibility `json:"visibility,omitempty"`
Copy link
Copy Markdown
Contributor

@jtopjian jtopjian Mar 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity:

This field was added with a microversion, but Cinder v3 support was merged using microversion 3.27 as the "base". So I consider anything prior to that to be grandfathered, such as this field.

Otherwise, this field would be a pointer, as recently changed here: #1854

Copy link
Copy Markdown
Contributor Author

@kayrus kayrus Mar 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about this? According to the latest code it is still checks for the explicit 3.1 microversion: https://github.com/openstack/cinder/blob/e921b3ae6c462f5f844485f7da7164e194efd00c/cinder/api/contrib/volume_actions.py#L232..L240

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian Mar 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - to clarify: Cinder v3 support was merged into Gophercloud using microversion 3.27 as the "base".

@kayrus kayrus force-pushed the upload-to-image-new-opts branch from b40c2de to 8b4647e Compare March 3, 2020 08:14
@kayrus kayrus force-pushed the upload-to-image-new-opts branch from 8b4647e to cd4227f Compare March 3, 2020 08:23
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Mar 3, 2020

Build failed.

jtopjian
jtopjian approved these changes Mar 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit 3e8758f into gophercloud:master Mar 3, 2020
@kayrus kayrus deleted the upload-to-image-new-opts branch March 3, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtopjian jtopjian jtopjian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cinder V3: Support "protected" and "visibility" parameters in "UploadImageOpts"

3 participants

@kayrus @coveralls @jtopjian