Skip to content

Cinder V3: Add volume transport support#1869

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
kayrus:volume-transfer
Mar 2, 2020
Merged

Cinder V3: Add volume transport support#1869
jtopjian merged 1 commit intogophercloud:masterfrom
kayrus:volume-transfer

Conversation

@kayrus
Copy link
Copy Markdown
Contributor

@kayrus kayrus commented Feb 29, 2020

Resolves #1868

@coveralls
Copy link
Copy Markdown

coveralls commented Feb 29, 2020

Coverage Status

Coverage increased (+0.05%) to 77.269% when pulling 4bf3c40 on kayrus:volume-transfer into 7cab38d on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Feb 29, 2020

Build succeeded.

@kayrus kayrus changed the title Cinver V3: Add volume transport support Cinder V3: Add volume transport support Mar 1, 2020
@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Mar 1, 2020

@jtopjian ready for review

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kayrus In general this is good to go - just a few cleanup items.

I left a comment about moving some code to results.go.

In addition, we need a doc.go file with some examples of how to use this.

@kayrus kayrus force-pushed the volume-transfer branch from ca5f807 to 4bf3c40 Compare March 2, 2020 06:28
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Mar 2, 2020

Build failed.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Mar 2, 2020

Build failed.

@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented Mar 2, 2020

I'll open an issue with OpenLab about the failing tests

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit 4cc0abf into gophercloud:master Mar 2, 2020
@kayrus kayrus deleted the volume-transfer branch March 2, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cinder V3: Add volume transfers support

3 participants