Identity V3: add Trust Get and List funcions#1855
Merged
jtopjian merged 2 commits intogophercloud:masterfrom Feb 16, 2020
Pirionfr:master
Merged
Identity V3: add Trust Get and List funcions#1855jtopjian merged 2 commits intogophercloud:masterfrom Pirionfr:master
jtopjian merged 2 commits intogophercloud:masterfrom
Pirionfr:master
Conversation
Implement Get and List functions for v3/extenstions/trusts package with unit tests and docs.
|
Build failed.
|
|
Build succeeded.
|
jtopjian
approved these changes
Feb 16, 2020
Contributor
jtopjian
left a comment
There was a problem hiding this comment.
LGTM
This is really nice work - thank you! And thank you for cleaning up the Trust result struct.
7 tasks
| "testing" | ||
|
|
||
| "github.com/gophercloud/gophercloud/openstack/identity/v3/extensions/trusts" | ||
|
|
Contributor
There was a problem hiding this comment.
Redundant empty line.
| "time" | ||
|
|
||
| "github.com/gophercloud/gophercloud/pagination" | ||
|
|
Contributor
There was a problem hiding this comment.
Redundant empty line.
Contributor
|
Oh I forgot about a browser tab with this PR 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Get and List functions for v3/extensions/trusts package
with unit tests and docs.
For #1642
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://github.com/openstack/keystone/blob/stable/stein/keystone/trust/core.py#L118
https://github.com/openstack/keystone/blob/stable/stein/keystone/api/trusts.py#L197
https://github.com/openstack/keystone/blob/stable/stein/keystone/api/trusts.py#L156