add fixedIPs filter on network port#1849
Merged
jtopjian merged 1 commit intogophercloud:masterfrom Feb 13, 2020
Merged
Conversation
|
Build failed.
|
Contributor
|
recheck |
|
Build succeeded.
|
jtopjian
approved these changes
Feb 13, 2020
Contributor
jtopjian
left a comment
There was a problem hiding this comment.
This uses slightly different conventions than other areas in Gophercloud, but I'm okay with this.
LGTM - thank you for working on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1847
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://docs.openstack.org/api-ref/network/v2/?expanded=list-ports-detail
https://github.com/openstack/neutron-lib/blob/478502b3dfb8c3ff66318169377251826563a398/neutron_lib/api/validators/__init__.py#L514-L551
https://github.com/openstack/neutron-lib/blob/56033ba643812a30577f6ab17648806c2ee494ba/neutron_lib/api/definitions/port.py#L62-L69
https://github.com/openstack/neutron/blob/79e6da0004a0e4e6996d2443121fdf84ae0eb34d/neutron/plugins/ml2/plugin.py#L2241