Skip to content

Add resource provider create API for placement.#1841

Merged
jtopjian merged 2 commits intogophercloud:masterfrom
dkt26111:master
Feb 9, 2020
Merged

Add resource provider create API for placement.#1841
jtopjian merged 2 commits intogophercloud:masterfrom
dkt26111:master

Conversation

@dkt26111
Copy link
Copy Markdown
Contributor

@dkt26111 dkt26111 commented Feb 6, 2020

For #526

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

API doc:
https://docs.openstack.org/api-ref/placement/#create-resource-provider

API code:
https://github.com/openstack/placement/blob/master/placement/handlers/resource_provider.py#L77

@coveralls
Copy link
Copy Markdown

coveralls commented Feb 6, 2020

Coverage Status

Coverage increased (+0.005%) to 77.049% when pulling 6ca36e3 on dkt26111:master into ca606dc on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Feb 6, 2020

Build succeeded.

@dkt26111
Copy link
Copy Markdown
Contributor Author

dkt26111 commented Feb 6, 2020

@jtopjian This is ready for review

@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented Feb 7, 2020

@dkt26111 This all looks good. Would you be able to add an example to doc.go?

@dkt26111
Copy link
Copy Markdown
Contributor Author

dkt26111 commented Feb 8, 2020

@dkt26111 This all looks good. Would you be able to add an example to doc.go?

Done.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Feb 8, 2020

Build succeeded.

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit 63bef1e into gophercloud:master Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants