Skip to content

Add missing options to CreateMemberOpts#1824

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
databus23:pool-create-member-missing-opts
Jan 15, 2020
Merged

Add missing options to CreateMemberOpts#1824
jtopjian merged 1 commit intogophercloud:masterfrom
databus23:pool-create-member-missing-opts

Conversation

@databus23
Copy link
Copy Markdown
Contributor

@databus23 databus23 commented Jan 14, 2020

For #1823

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

https://docs.openstack.org/api-ref/load-balancer/v2/#create-member

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 14, 2020

Coverage Status

Coverage remained the same at 77.057% when pulling 7efbb46 on databus23:pool-create-member-missing-opts into 79f393b on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jan 14, 2020

Build succeeded.

@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented Jan 14, 2020

@databus23 Thank you for submitting this.

Would you be able to provide references to the actual Octavia/LBaaS code that supports these additions? Please see here for more information and let me know if you have any questions.

@databus23
Copy link
Copy Markdown
Contributor Author

databus23 commented Jan 14, 2020

Sure. In addition to the api docs the parameters are mentioned hier:
https://github.com/openstack/octavia/blob/80f464764854cacda70d59bbca43d64fa797705d/octavia/api/v2/types/member.py#L83 and
https://github.com/openstack/octavia/blob/80f464764854cacda70d59bbca43d64fa797705d/octavia/api/v2/types/member.py#L79

Also here in the Member model: https://github.com/openstack/octavia/blob/3cce347129fe51c219d9630a96b568633eef0098/octavia/common/data_models.py#L344-L349 or here
https://github.com/openstack/octavia/blob/3cce347129fe51c219d9630a96b568633eef0098/octavia/db/models.py#L201-L203

Take your pick :)

jtopjian
jtopjian approved these changes Jan 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit 1236c25 into gophercloud:master Jan 15, 2020
@databus23 databus23 deleted the pool-create-member-missing-opts branch January 15, 2020 07:55
@mtneug mtneug mentioned this pull request Nov 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtopjian jtopjian jtopjian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@databus23 @coveralls @jtopjian