Skip to content

Fix sort_key / sort_keys#1809

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
snigle:patch-2
Jan 8, 2020
Merged

Fix sort_key / sort_keys#1809
jtopjian merged 1 commit intogophercloud:masterfrom
snigle:patch-2

Conversation

@snigle
Copy link
Copy Markdown
Contributor

@snigle snigle commented Jan 6, 2020

Just add missing s in sort_keys query param of cron triggers :
https://docs.openstack.org/mistral/latest/api/v2.html#get--v2-workflows

For #1808

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

https://github.com/openstack/mistral/blob/master/mistral/api/controllers/v2/cron_trigger.py#L119

Just add missing s in sort_keys query param of cron triggers : 
https://docs.openstack.org/mistral/latest/api/v2.html#get--v2-workflows
@coveralls
Copy link
Copy Markdown

coveralls commented Jan 6, 2020

Coverage Status

Coverage remained the same at 77.027% when pulling 79ffcb0 on snigle:patch-2 into a06ca87 on gophercloud:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-1.4%) to 75.624% when pulling 79ffcb0 on snigle:patch-2 into a06ca87 on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jan 6, 2020

Build succeeded.

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit 4d9bb63 into gophercloud:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants