Containerinfra: nodegroups Create/Update/Delete#1800
Containerinfra: nodegroups Create/Update/Delete#1800jtopjian merged 13 commits intogophercloud:masterfrom
Conversation
|
Another thing to consider for the acceptance tests running in CI, these tests require creating four VMs.
I don't know how much memory the testing environment has available, if it can't support four VMs then I can change to not update the min_node_count and have three VMs in total. Lower than three is not possible. |
|
Build failed.
|
d8e5653 to
c62fd83
Compare
|
Build failed.
|
That sounds good. In addition, we can always disable this test if we find it is too resource intensive. Having the acceptance test included, even if disabled, is still very useful for both documentation as well as being able to run the test manually from time to time. |
jtopjian
left a comment
There was a problem hiding this comment.
LGTM - thank you again for all of your work.
For #1767
Create method:
https://github.com/openstack/magnum/blob/9c7cf5d6eb050dbbcdcb036bd0af2b6586070c0c/magnum/api/controllers/v1/nodegroup.py#L283-L323
Available fields when creating node group:
https://github.com/openstack/python-magnumclient/blob/c0d368360831cd29affa47e77eba4e81e4c6f0f8/magnumclient/v1/nodegroups.py#L21-L23
Update method:
https://github.com/openstack/magnum/blob/9c7cf5d6eb050dbbcdcb036bd0af2b6586070c0c/magnum/api/controllers/v1/nodegroup.py#L326-L338
Delete method:
https://github.com/openstack/magnum/blob/9c7cf5d6eb050dbbcdcb036bd0af2b6586070c0c/magnum/api/controllers/v1/nodegroup.py#L341-L355