Containerinfra: acceptance test timeout changes and fixes#1794
Merged
jtopjian merged 5 commits intogophercloud:masterfrom Dec 10, 2019
Merged
Containerinfra: acceptance test timeout changes and fixes#1794jtopjian merged 5 commits intogophercloud:masterfrom
jtopjian merged 5 commits intogophercloud:masterfrom
Conversation
To be used in situations where a 300 second timeout is not long enough or otherwise unsuitable. The WaitFor function is changed to simply call WaitForTimeout and pass the same 300 second timeout, keeping the same behaviour.
Keeps the same timeout as previously by default, but can be changed for cluster templates that require a longer timeout.
Required for compatibility with Magnum APIs running on Python 3. See gophercloud#1458 and gophercloud#1463
With the storage driver set to devicemapper the magnum API did not accept clusters created with the template, as docker_volume_size was not set. Instead of setting the volume size, overlay2 can be used with no volume and is the preferred storage driver.
|
Build failed.
|
Contributor
|
recheck |
|
Build failed.
|
Contributor
|
recheck |
|
Build failed.
|
Contributor
|
recheck |
|
Build failed.
|
Contributor
|
@tghartland I'm going to merge this one, too. Once we get Magnum integrated in OpenLab, we can look at fixing any errors, if needed. Thank you very much for your work on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1767
Adds configurable timeouts to cluster creation which will be needed for kubernetes clusters, to be able to test node groups. A kubernetes cluster needs longer than 5 minutes to create.
There are also some fixes for the existing clusters API acceptance tests.
I have tried to make as few changes and additions as possible to the existing code, by making the existing functions just call to the versions that accept a timeout.
With these fixes, the cluster acceptance tests pass in my devstack on magnum master branch.
For the tests in CI, the timeouts may need to be tweaked.