[wip] FWaaS v2.0 Rule List#1783
Conversation
|
Build failed.
|
|
recheck |
|
Build failed.
|
|
recheck |
|
@jtopjian Openlab checks failing. Doesn't seem to be related to my code though :) |
|
Build succeeded.
|
|
@jtopjian There we go. Recheck successful :) |
jtopjian
left a comment
There was a problem hiding this comment.
@Elethiomel Thanks!
I've left two comments in regards to ListOpts. And for some reason, Update is getting mixed in here. Please let me know if you have any questions.
| DestinationIPAddress string `q:"destination_ip_address"` | ||
| SourcePort string `q:"source_port"` | ||
| DestinationPort string `q:"destination_port"` | ||
| Enabled bool `q:"enabled"` |
There was a problem hiding this comment.
By default, Gophercloud does not set zero-values in the query strings. Using bool, we'll only ever be able to query ?enabled=true. We should change this to *bool so we can do ?enabled=false.
| DestinationPort string `q:"destination_port"` | ||
| Enabled bool `q:"enabled"` | ||
| ID string `q:"id"` | ||
| Shared bool `q:"shared"` |
| return | ||
| } | ||
|
|
||
| // UpdateOptsBuilder is the interface options structs have to satisfy in order |
There was a problem hiding this comment.
I think this PR might need rebased off of Gophercloud's master branch. Update has already been merged: https://github.com/gophercloud/gophercloud/blob/master/openstack/networking/v2/extensions/fwaas_v2/rules/requests.go#L93
There was a problem hiding this comment.
Whoops :D Good catch, thanks!
|
Build succeeded.
|
|
@jtopjian Look OK to you? |
|
@Elethiomel I apologize for the delay. I will review this as soon as I get a chance. |
|
@Elethiomel It looks like you've got a good understanding of how to implement this, including understanding how it relates to the Python-based service code. Please feel free to combine CRUD into a single PR for the rest of the resources. |
For #514