Skip to content

[wip] FWaaS v2.0 Rule Get (depends on PR 1771)#1772

Merged
jtopjian merged 15 commits intogophercloud:masterfrom
Elethiomel:fwaasv2_rule_get
Nov 26, 2019
Merged

[wip] FWaaS v2.0 Rule Get (depends on PR 1771)#1772
jtopjian merged 15 commits intogophercloud:masterfrom
Elethiomel:fwaasv2_rule_get

Conversation

@Elethiomel
Copy link
Copy Markdown
Contributor

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 19, 2019

Coverage Status

Coverage increased (+0.004%) to 76.978% when pulling ebd52e1 on Elethiomel:fwaasv2_rule_get into d8ac278 on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Nov 19, 2019

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Nov 22, 2019

Build failed.

@Elethiomel
Copy link
Copy Markdown
Contributor Author

@jtopjian I'm not 100% sure what happened here. It looks like the testing bombed out due to another reason. My acceptance tests are passing locally.

@jtopjian
Copy link
Copy Markdown
Contributor

recheck

@jtopjian
Copy link
Copy Markdown
Contributor

@Elethiomel Yeah, it's either a transient error or a change in the OpenStack API causing a test to fail. If it happens again, we'll ignore it for this PR.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Nov 25, 2019

Build failed.

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit 8eab178 into gophercloud:master Nov 26, 2019
@Elethiomel Elethiomel deleted the fwaasv2_rule_get branch December 2, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants