[wip] FWaaS v2.0 Rule Delete (depends on PR 1768)#1771
Merged
jtopjian merged 15 commits intogophercloud:masterfrom Nov 22, 2019
Merged
[wip] FWaaS v2.0 Rule Delete (depends on PR 1768)#1771jtopjian merged 15 commits intogophercloud:masterfrom
jtopjian merged 15 commits intogophercloud:masterfrom
Conversation
|
Build succeeded.
|
|
Build succeeded.
|
Contributor
Author
|
@jtopjian PR2 in what will probably be 16 or so ready for review :) |
Contributor
|
@Elethiomel Thanks! I should have time to review this within the next day. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #514
https://github.com/openstack/neutron-fwaas/blob/27906d0acff349c9e5ac7955d203fb2233c295db/neutron_fwaas/db/firewall/v2/firewall_db_v2.py#L68-L82