Compute v2: Move ServerTagsExt to servers.TagsExt#1760
Merged
jtopjian merged 1 commit intogophercloud:masterfrom Oct 24, 2019
Merged
Compute v2: Move ServerTagsExt to servers.TagsExt#1760jtopjian merged 1 commit intogophercloud:masterfrom
jtopjian merged 1 commit intogophercloud:masterfrom
Conversation
This commit moves the tags extension's ServerTagsExt to the servers package. While this is slighly nuanced, the tags extension can be thought of to work directly on a server's tags and the ability to extract a server's tags can be part of the servers package since the original ExtractTags microversion support already exists.
Contributor
Author
|
@ozerovandrei after looking at gophercloud/openstack/compute/v2/extensions/tags/results.go Lines 5 to 9 in 0907b32 I see the benefit to having a struct extension like you made since there is not an easy way to see the tags from a list of servers. But since we already have the ability to extract tags from a single server result in Like the commit message says, this is slightly nuanced / nit picking, so I'm open to discussion on this. |
|
Build succeeded.
|
ozerovandrei
approved these changes
Oct 24, 2019
Contributor
ozerovandrei
left a comment
There was a problem hiding this comment.
Looks great, thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit moves the tags extension's ServerTagsExt to
the servers package. While this is slighly nuanced, the tags
extension can be thought of to work directly on a server's
tags and the ability to extract a server's tags can be part
of the servers package since the original ExtractTags
microversion support already exists.
For #1669