Identity V3: Add access rules support for application credentials#1758
Identity V3: Add access rules support for application credentials#1758jtopjian merged 3 commits intogophercloud:masterfrom
Conversation
|
Build succeeded.
|
Do you mean because you are currently re-using Technically, we can't use On the other hand, this kind of re-use is done in in a few other places already. In addition, there are a lot of So there are two options:
Thoughts? |
|
recheck |
|
@jtopjian probably the first option is the best choice. I don't have a use case to fetch and process links attribute for an individual access rule and even an application credential. |
|
Build failed.
|
|
Sorry, I completely forgot about this last week: #1761 I'll try to get to this later today. |
|
recheck |
|
Build failed.
|
|
Build failed.
|
|
Build succeeded.
|
|
@jtopjian ready for review |
| // The expiration time of the application credential, if one was specified. | ||
| ExpiresAt time.Time `json:"-"` | ||
| // Links contains referencing links to the application credential. | ||
| Links map[string]interface{} `json:"links"` |
There was a problem hiding this comment.
Let's add this back. I mentioned that no one has noticed when these fields are missing, but I'd prefer to leave the existing ones in place just in case they're being used somewhere.
|
Build succeeded.
|
Resolves #1757
acceptance tests will be added later
@jtopjian not sure whether I need to create a separate struct to create access rules