Skip to content

Auth: Allow TokenID passthrough when the scope is not set#1752

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
kayrus:auth-token-passthrough
Oct 19, 2019
Merged

Auth: Allow TokenID passthrough when the scope is not set#1752
jtopjian merged 1 commit intogophercloud:masterfrom
kayrus:auth-token-passthrough

Conversation

@kayrus
Copy link
Copy Markdown
Contributor

@kayrus kayrus commented Oct 17, 2019

@kayrus kayrus force-pushed the auth-token-passthrough branch from 373ce68 to 4d83c63 Compare October 17, 2019 14:03
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.07%) to 76.929% when pulling 4d83c63 on kayrus:auth-token-passthrough into f2af868 on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Oct 17, 2019

Build failed.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Oct 17, 2019

recheck

@jtopjian
Copy link
Copy Markdown
Contributor

I think there's an issue with OpenLab building the ironic environment. I think I've pinned it down - just need to find a minute to review and open an issue :)

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Oct 17, 2019

Build failed.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Oct 18, 2019

recheck

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Oct 18, 2019

Build succeeded.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Oct 18, 2019

@jtopjian ready for review

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian
Copy link
Copy Markdown
Contributor

@kayrus Thank you for looking into this.

@jtopjian jtopjian merged commit 2f683dc into gophercloud:master Oct 19, 2019
@kayrus kayrus deleted the auth-token-passthrough branch October 19, 2019 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auth: introduce token auth

3 participants