Fixes Load Balancer Flavor Selection#1744
Merged
jtopjian merged 1 commit intogophercloud:masterfrom Oct 16, 2019
kmbulebu:master
Merged
Fixes Load Balancer Flavor Selection#1744jtopjian merged 1 commit intogophercloud:masterfrom kmbulebu:master
jtopjian merged 1 commit intogophercloud:masterfrom
kmbulebu:master
Conversation
Contributor
Author
|
I'll fix up the tests and get this to a passing. |
The attribute to specify a Load Balancer flavor by ID is 'flavor_id' and not 'flavor' for both Octavia and Neutron LBaaSv2. References: https://docs.openstack.org/api-ref/network/v2/#load-balancer-as-a-service-2-0-deprecated https://docs.openstack.org/api-ref/load-balancer/v2/?expanded=create-a-load-balancer-detail#create-a-load-balancer
|
Build succeeded.
|
Contributor
Author
|
I'm done. Please consider for review. I believe the code coverage results are reporting a false negative in line count decrease. I reviewed to make sure the change didn't send execution down an unexpected path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The attribute to specify a Load Balancer flavor by ID
is 'flavor_id' and not 'flavor' for both Octavia and
Neutron LBaaSv2.
For #1743
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
Octavia Source: https://github.com/openstack/octavia/blob/master/octavia/api/v2/types/load_balancer.py#L55
Octavia API Ref: https://docs.openstack.org/api-ref/load-balancer/v2/?expanded=create-a-load-balancer-detail#create-a-load-balancer
Neutron LBaaSv2 Source: https://review.opendev.org/gitweb?p=openstack/neutron-lbaas.git;a=blob;f=neutron_lbaas/services/loadbalancer/data_models.py;h=d44cc8dd5d543af9ffacb7bc1954f332083fdc67;hb=refs/heads/stable/rocky#l724
Neutron LBaaSv2 API Ref: https://docs.openstack.org/api-ref/network/v2/#load-balancer-as-a-service-2-0-deprecated (docs page currently broken)