Octavia LBaaS v2: Allow unsetting the member's subnet id in batch mem…#1738
Merged
jtopjian merged 1 commit intogophercloud:masterfrom Oct 13, 2019
Merged
Conversation
|
Build succeeded.
|
Contributor
Author
|
@jtopjian ready for review |
Contributor
|
But if we're now changing the types of the update struct, we shouldn't do this by modifying the create struct. There are other areas on Gophercloud where create and update look the same except update has pointers for types to account for unsetting values. I suggest we unalias |
Contributor
Author
|
@jtopjian good point |
5884125 to
20fb69c
Compare
20fb69c to
db72cb6
Compare
|
Build succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1737