Skip to content

Octavia LBaaS v2: Allow unsetting the member's subnet id in batch mem…#1738

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
kayrus:members-unset-subnetid
Oct 13, 2019
Merged

Octavia LBaaS v2: Allow unsetting the member's subnet id in batch mem…#1738
jtopjian merged 1 commit intogophercloud:masterfrom
kayrus:members-unset-subnetid

Conversation

@kayrus
Copy link
Copy Markdown
Contributor

@kayrus kayrus commented Oct 10, 2019

Resolves #1737

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 10, 2019

Coverage Status

Coverage decreased (-0.5%) to 76.889% when pulling db72cb6 on kayrus:members-unset-subnetid into 9c34d19 on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Oct 10, 2019

Build succeeded.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Oct 10, 2019

@jtopjian ready for review

@jtopjian
Copy link
Copy Markdown
Contributor

BatchUpdateMemberOpts is an alias to CreateMemberOpts. This was most likely done out of convenience because the two shared fields.

But if we're now changing the types of the update struct, we shouldn't do this by modifying the create struct. There are other areas on Gophercloud where create and update look the same except update has pointers for types to account for unsetting values.

I suggest we unalias BatchUpdateMemberOpts and make it a first-class struct.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Oct 11, 2019

@jtopjian good point

@kayrus kayrus force-pushed the members-unset-subnetid branch from 5884125 to 20fb69c Compare October 11, 2019 18:04
@kayrus kayrus force-pushed the members-unset-subnetid branch from 20fb69c to db72cb6 Compare October 11, 2019 18:34
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Oct 11, 2019

Build succeeded.

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit f1122b7 into gophercloud:master Oct 13, 2019
@kayrus kayrus deleted the members-unset-subnetid branch October 14, 2019 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Octavia LBaaS v2: Allow unsetting the member's subnet id in batch members update

3 participants