Skip to content

Add disk/by_path to available introspection data#1730

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
redixin:add-by-path
Oct 7, 2019
Merged

Add disk/by_path to available introspection data#1730
jtopjian merged 1 commit intogophercloud:masterfrom
redixin:add-by-path

Conversation

@redixin
Copy link
Copy Markdown
Contributor

@redixin redixin commented Oct 4, 2019

Disk by path (e.g. /dev/disk/by-path/pci-0000:00:07.0) is available in
ironic inspector results and may be required by some projects.

Tested and works as expected.

#1733

Disk by path (e.g. /dev/disk/by-path/pci-0000:00:07.0) is available in
ironic inspector results and may be required by some projects.
@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented Oct 4, 2019

@redixin Thanks.

Please open a corresponding issue to link this PR to or use an existing issue. Also, please provide the Ironic Inspection python code that defines by_path. Let me know if you have any questions.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 76.892% when pulling 067a3ea on redixin:add-by-path into d845749 on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Oct 4, 2019

Build failed.

@redixin
Copy link
Copy Markdown
Contributor Author

redixin commented Oct 6, 2019

@jtopjian I've added issue with link to python agent code and updated this pull request. How to deal with failed tests?

@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented Oct 6, 2019

recheck

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Oct 7, 2019

Build succeeded.

@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented Oct 7, 2019

@redixin Thanks! The OpenLab failure was transient and just needed re-run. The travis error has been fixed in another PR.

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit 88bb612 into gophercloud:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants