Identity V3: Add ExtractDomain method for the identity/v3/tokens package#1712
Merged
jtopjian merged 2 commits intogophercloud:masterfrom Sep 19, 2019
Merged
Identity V3: Add ExtractDomain method for the identity/v3/tokens package#1712jtopjian merged 2 commits intogophercloud:masterfrom
jtopjian merged 2 commits intogophercloud:masterfrom
Conversation
Contributor
|
@kayrus Thanks! Can you include a unit test with a domain-scoped fixture? Please don't copy and paste from the API docs, though - it should be a new fixture generated from a running OpenStack environment or devstack. |
|
Build failed.
|
Contributor
Author
|
@jtopjian I issued the token response from my environment as a base, then I copy-pasted the catalog and userids from the initial fixtures. I hope it is fine. |
76f1d31 to
4e9c420
Compare
|
Build failed.
|
Contributor
Author
|
@jtopjian @huangtianhua looks like the |
Contributor
|
Good find. I think this test has made more progress than previous ones - prior test failures haven't gotten to the point of running any tests. There might be an issue with devstack creating the subnet: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1711