Skip to content

Identity V3: Add ExtractDomain method for the identity/v3/tokens package#1712

Merged
jtopjian merged 2 commits intogophercloud:masterfrom
kayrus:token-domain-scope
Sep 19, 2019
Merged

Identity V3: Add ExtractDomain method for the identity/v3/tokens package#1712
jtopjian merged 2 commits intogophercloud:masterfrom
kayrus:token-domain-scope

Conversation

@kayrus
Copy link
Copy Markdown
Contributor

@kayrus kayrus commented Sep 18, 2019

Resolves #1711

@coveralls
Copy link
Copy Markdown

coveralls commented Sep 18, 2019

Coverage Status

Coverage increased (+0.008%) to 77.639% when pulling 4e9c420 on kayrus:token-domain-scope into c1ae5ed on gophercloud:master.

@jtopjian
Copy link
Copy Markdown
Contributor

@kayrus Thanks!

Can you include a unit test with a domain-scoped fixture? Please don't copy and paste from the API docs, though - it should be a new fixture generated from a running OpenStack environment or devstack.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Sep 18, 2019

Build failed.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Sep 18, 2019

@jtopjian I issued the token response from my environment as a base, then I copy-pasted the catalog and userids from the initial fixtures. I hope it is fine.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Sep 18, 2019

Build failed.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Sep 18, 2019

@jtopjian @huangtianhua looks like the OS_SUBNET_ID environment variable disappeared from the openlab landscape:

2019-09-18 12:02:26.714328 | ubuntu-xenial | +++ openrc:source:117                        :   export OS_SUBNET_ID=
2019-09-18 12:02:26.717761 | ubuntu-xenial | +++ openrc:source:117                        :   OS_SUBNET_ID=

@jtopjian
Copy link
Copy Markdown
Contributor

Good find. I think this test has made more progress than previous ones - prior test failures haven't gotten to the point of running any tests.

There might be an issue with devstack creating the subnet:

2019-09-18 19:13:50.869488 | ubuntu-xenial | +++ ./script/stackenv:source:10              :   openstack subnet show private_subnet -c id -f value
2019-09-18 19:13:54.007126 | ubuntu-xenial | No Subnet found for private_subnet

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Identity V3: Add ExtractDomain method for the identity/v3/tokens package

3 participants