Octavia: Support allowed_cidrs for listener#1710
Merged
jtopjian merged 1 commit intogophercloud:masterfrom Sep 19, 2019
Merged
Conversation
6535e3e to
17b6149
Compare
|
Build failed.
|
17b6149 to
2374b10
Compare
|
Build failed.
|
Contributor
|
@lingxiankong I trust this is correct, but can you provide the Octavia server-side API code that defines Also, please ignore the OpenLab failures. I have an open ticket to get that resolved. |
Contributor
Author
|
@jtopjian Commit message updated. |
jtopjian
approved these changes
Sep 19, 2019
Contributor
jtopjian
left a comment
There was a problem hiding this comment.
My testing environment isn't new enough to have allowed_cidrs support but testing works if I don't set AllowedCIDRs, so backwards compatibility is fine.
I'm sure this works in the appropriate environments, so this LGTM. Thank you!
Contributor
|
recheck |
|
Build succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1709
Links to the line numbers/files in the OpenStack source code that support the
code in this PR: