Merged
Conversation
Contributor
Author
|
@jtopjian This is ready for review |
|
Build succeeded.
|
jtopjian
requested changes
Sep 7, 2019
| // the port forwarding attributes you want to see returned. SortKey allows you to | ||
| // sort by a particular network attribute. SortDir sets the direction, and is | ||
| // either `asc' or `desc'. Marker and Limit are used for pagination. | ||
| type ListOpts struct { |
Contributor
There was a problem hiding this comment.
We need to add limit (int) and marker (string) here.
Gophercloud's paging automatically sets limit and marker when paging internally, but if the user wanted to limit the results themselves, we need that in ListOpts.
Contributor
Author
|
@jtopjian I added the |
|
Build succeeded.
|
Contributor
|
@simonre sorry for the delay - I'm out of the office. Thank you! |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to a PR being reviewed, there needs to be a Github issue that the PR
addresses. Replace the brackets and text below with that issue number.
For #1637
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
Source:
https://github.com/openstack/neutron/blob/f21444f247108212dc835036c98e354d6e6f7ace/neutron/services/portforwarding/pf_plugin.py#L487
API:
https://docs.openstack.org/api-ref/network/v2/?expanded=create-port-forwarding-detail#list-floating-ip-port-forwardings